metadata doesn't update after sync anymore

Cambionn · July 31

Hey!

This once was an issue, but got fixed ages ago. It seems somewhere in the later updates, this issue has been brought back.

When I change metadata, but not the file name, Astiga never updates the new metadata on sync. Due to this, a typo in for example album names stay stuck. This is especially annoying on album names, track titles and artist names as that means the scrobbles also get messed up (but shouldn't really happen anywhere).

For now, I ran a separate sync with force refresh on the folders of the affected albums, but that is more a work around than a fix.

gravelld · July 31

Can you link to where it got fixed previously? From memory, sync has always been based on filename rather than modified date.

Cambionn · September 2

I can't seem to find it back. But I'm near certain that updating metadata without changing file names used to work.

Either way, regardless of what it used to do I would expect updating on sync to be the desired behavior. After all, you don't want to have to alter your naming standards for fixing typo's or updating cover art.

gravelld · September 2

I'll review this 👍️

gravelld · September 4

I think I can see the problem. Synchronisation relies on the storage integration (SFTP in your case) returning an identifier that identifies the revision of a file (we call this a "tag"). The SFTP integration doesn't include this, therefore files are not differentiated when they are updated.

However, I think we should be able to see the mtime for each file. If this works out (I should spike it) I think we could generate a tag combining the path and the mtime. I think that should work.

Cambionn · September 10

That would explain why I thought it worked before. My previous storages used different integrations.

Hope it works, sounds like a decent fix!

gravelld · September 10

We've implemented this. Here are the next steps:

We'll set up a test version of the sync server.
I'll send a resync for your account - this will resync everything because all of the tags are now set.
You change some metadata on a file and make sure it's updated in the storage. Change a field we actually use (you can see these under the "... -> Details" for songs)
I'll send a new resync through, and see if the change is taken.

gravelld · September 15

I've completed steps 1 and 2, so could you edit some metadata and let me know the path to the file(s) changed? (You could try a few if you like, and send via email).

gravelld · September 25

In the absence of any further testing, we'll deploy the fix to the sync process in production next week. Let us know if it works...

Oh - note that the "tags" I referred to before aren't currently generated on your library. You'll need a full refresh for that. So once the new version is out, give it a go.

gravelld · September 30

This is in production now: https://community.asti.ga/discussion/comment/4256/#Comment_4256

Cambionn · October 1

Sorry. I don't get email about updates here and I don't always remember to check manually. I will try to refresh the whole library and test once I have some time!

gravelld · October 1

Sweet, thanks!

Cambionn · October 22

Sadly, it doesn't seem to work. I tried editing some album names that where wrong, but I didn't update in Astiga (Maki Goto's Ai Kotoba (Voice) Disc 2 should be Sweet Black).

gravelld · October 23

Thanks, will check this.

Cambionn · October 23

I just noticed a newly added song that had a mistake did get updated after changing it.

I did do a complete resync after you fixed it, but I wonder if maybe something didn't go entirely right there and a new complete resync might fix it. I will try that later today. I need to plan because my music will be gone for a while and slowly come back 😅

gravelld · October 23

Yes, I understand... please let me know when you've tested it.

Cambionn · October 24

Hmmm. I have another new track, but when I changed the cover art from that one it doesn't get updated. Not sure why, but it seems that it sometimes works, but sometimes not.

Anyways, running a full resync now.

gravelld · October 25

Ok - it might require some extra logging. Let me know how it goes.

Cambionn · November 11

Messing with the multi-genre stuff now. Sadly too busy making it a bit later than planned. Can't react on that threat but seems to be working from your side. But anyways.

I fear this issue is still a hit or miss situation. It works at times, and not at others.

For example, F5ve - Sequence 01 didn't update to contain both genre pages. This album was first added a few weeks ago after the update, so definitely no old data without the fix.

I had other moments where it did work fine however.

gravelld · November 11

didn't update to contain both genre pages

Do you mean the album page didn't update to show both genres, or the genres list didn't show both the new genres?

Cambionn · November 12

The album page didn't show both genres. But the changes aren't synchronised at all. That one had a pre-existing secondairy genre added. But newly added genres don't show up at all.

When syncing new files it does work. The multi-genre thing works fine. It's just not getting synchronised, other metadata changes also aren't getting synced. Now showing up is simply a symptom of that.

But sometimes it does get synced. I'm not entirely sure yet about what causes it to do and do not get synced.

gravelld · November 12

We need to try to narrow down an instance so I can see why the changes aren't being calculated. Do you have a file with outstanding changes that still isn't being synced? How about F5ve - Sequence 01? I should be able to look into the logs for that file. Let me know what the path is; by email if you like.

Oh - just looked that one up. There's currently no tag for the file - so one wasn't generated during sync. This is what we depend on for last modified logic. I'll look into it tomorrow.

gravelld · November 13

Well... this is embarrassing. It turns out that when we made the original change available on the staging server we didn't afterwards integrate this into the master branch of code, thus it's not actually deployed.

I've just done this, so it should be available from the next build.

In the meantime, does force refresh work on just this folder?

Cambionn · 12:02PM

Well... this is embarrassing. It turns out that when we made the original change available on the staging server we didn't afterwards integrate this into the master branch of code, thus it's not actually deployed.

No worries, things happen. At least it's easy to find the issue and fix lol.

In the meantime, does force refresh work on just this folder?

It does, but last time I did this it caused some other oddities where that folder would not be synced with a full sync anymore, as if it became it's own special little syncing sandbox. It was however very long (years) ago and those might already be fixed.

I'm gonna need quite some time to re-tag all the audio, so I'm not too rushing to resync everything and can wait for the next build. Something with hundreds of albums and track-specific tags causing me to go over each track almost one by one.

At least once we get multi-artist, I can pick out the tracks with multiple artists only. That's way more limited and easier to decide which tag to use 🤣.

gravelld · 4:20PM

It does, but last time I did this it caused some other oddities where that folder would not be synced with a full sync anymore, as if it became it's own special little syncing sandbox

That definitely shouldn't happen now.

I'm gonna need quite some time to re-tag all the audio

I might not understand you, but you don't need to change any tags - when I refer to "tag" above this is not a metadata tag but a label we generate which includes the last modified date.

You'd be best doing it after we've shipped this change.

metadata doesn't update after sync anymore

Comments